Bump Makie compat to v0.21 #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not working at the moment because there are some strange interactions. Maybe it would be better to simply use a GeoAxis and let GeoMakie handle the conversion logic, that is currently done in Tyler.
Compat is a pain and we can do the file type check using the magic bits from FileIO.
|
It looks like this one is good to go. Should we merge? So, that #91 also works. |
|
It still doesn't fix the weird overlapping issue :(...I'm going to try and at least reproduce to figure out what the hell is going on |
|
I guess we could merge and just not release though. |
|
So this is not fixing #82? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #76.
This PR must also fix #82 before we can merge it.
Changelog:
Mapto take anyMakie.AbstractAxis(so LScene, GeoAxis, etc)debug_tile!