Fix cross_repo for node_js repositories #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fryguy
approved these changes
Apr 26, 2024
NodeJS repositories were running bin/setup plus npm install which was causing failures.
agrare
force-pushed
the
fix_node_js_install
branch
from
a229878
to
6c24057
Compare
agrare
commented
Apr 26, 2024
| "script" => "npm test" | ||
| "language" => "node_js", | ||
| "node_js" => ["18"], | ||
| "before_script" => "yarn", |
There was a problem hiding this comment.
NOTE we are parsing "Prepare tests" as "before_script" which for ui-service runs bin/setup. The issue was we were running install AND before_script which was causing the failure because npm install was failing and not the intended way to do the install.
|
I created a "test" When that is green then this is okay to merge. |
agrare
added a commit
that referenced
this pull request
Apr 26, 2024
Fixed * Fix nodejs install not being overridden by repo ci.yml (#109)
|
Released this fix in v2.3.1 https://rubygems.org/gems/manageiq-cross_repo/versions/2.3.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NodeJS repositories were running bin/setup plus npm install which was causing failures.