Upgrade to yarn 3 #7904
Merged
Upgrade to yarn 3 #7904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some comments on commits Fryguy/manageiq-ui-classic@d66a46d~...d3e1399 .yarn/releases/yarn-3.0.2.cjs
lib/tasks/manageiq/ui_tasks.rake
|
|
Checked commits Fryguy/manageiq-ui-classic@d66a46d~...d3e1399 with ruby 2.6.3, rubocop 1.13.0, haml-lint 0.35.0, and yamllint |
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Oct 8, 2021
From Pull Request: ManageIQ/manageiq-ui-classic#7904
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Oct 8, 2021
From Pull Request: ManageIQ/manageiq-ui-classic#7904
|
Cross repo tests are green - I still want to do some more manual tests and verify certain things like direct yarn and npm commands still working |
kavyanekkalapu
approved these changes
Oct 19, 2021
|
@Fryguy Looks good to me. I loaded all the prs (ui-classic + providers + v2v) in my local and did some random testing in ui pages. It is working as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7903