Use rails 7 cache format as 7 can read either 6 or 7 #23210
Conversation
jrafanie
force-pushed
the
use_rails7_cache_format_version
branch
from
4a2abca
to
7838a74
Compare
|
Checked commit jrafanie@7838a74 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint config/application.rb
|
|
Not sure if the rubocop is important or not |
|
Huh. I wonder what class is there - if it is a Maybe ask if the |
It's a float. It's worrying about precision in case you do math operations. This is a straight comparison with a fixed float so I think we can ignore it. Let me kick the failing sporadic auth failure. |
| # TODO: Remove this once we move to config.load_defaults 7.0 as this is the default. | ||
| # Note, rails 7 can read cache format from 6 or 7 so there is no risk if you're running rails 7. | ||
| # See: https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#new-activesupport-cache-serialization-format | ||
| warn "Warning: Remove redundant config.active_support.cache_format_version = 7.0 from #{__FILE__}:#{__LINE__ + 1} if using config.load_defaults 7.0" if config.active_support.cache_format_version == 7.0 |
There was a problem hiding this comment.
note, this is nil if you load defaults earlier than 7.0
There was a problem hiding this comment.
Will we get these warnings for a while while we support both 6 and 7?
Or are we dropping 6 super quick as we migrate to 7.2 land?
There was a problem hiding this comment.
This warning will only occur when we're on rails 7.0+ where we're using config.load_defaults 7.0 or newer. It's a reminder to remove this setting when #23176 is merged.
|
Ok, this is ready to go. |
See: https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#new-activesupport-cache-serialization-format
Extracted from #23176