Skip to content

Commit

Permalink
code review
Browse files Browse the repository at this point in the history
  • Loading branch information
Kevingislason committed Dec 23, 2021
1 parent cd6455c commit 1a33e60
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 10 deletions.
3 changes: 2 additions & 1 deletion release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ The version numbers in the following files must be updated:
2. ui/src-tauri/Cargo.toml
3. ui/src-tauri/tauri.conf.json
4. ui/public/about.html
5. ui/package.json
EOF
prompt "Did you update the version numbers?"

Expand Down
3 changes: 2 additions & 1 deletion src/service.rs
Original file line number Diff line number Diff line change
Expand Up @@ -369,8 +369,9 @@ where
/// Sends version to the client.
#[inline]
async fn version(request: Request<A>) -> ServerResult {
Self::log(String::from("VERSION")).await?;
Self::log(String::from("REQUEST: version")).await?;
let _ = request;
Self::log(format!("RESPONSE: {:?}", VERSION)).await?;
Ok(Body::from_json(&VersionMessage::default())?.into())
}

Expand Down
4 changes: 2 additions & 2 deletions ui/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "manta-signer-ui",
"version": "0.4.0",
"version": "0.5.0",
"private": true,
"dependencies": {
"@tauri-apps/api": "^1.0.0-beta.8",
Expand Down Expand Up @@ -43,4 +43,4 @@
"devDependencies": {
"@tauri-apps/cli": "^1.0.0-beta.10"
}
}
}
12 changes: 6 additions & 6 deletions ui/public/about.html
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,11 @@ <h3>Manta Signer</h3>
<p>Version 0.5.0</p>
<p>Copyright © 2019-2021 Manta Network</p>
<p>
<a href="https://github.com/manta-network/manta-signer">manta-network/manta-signer</a
>
</p>
<br />
<p style="font-size: 0.75em; color: red">DOLPHIN TESTNET</p>
<a href="https://github.com/manta-network/manta-signer">manta-network/manta-signer</a>
</p>
<br />
<p style="font-size: 0.75em; color: red">DOLPHIN TESTNET</p>
</main>
</body>
</body>

</html>

0 comments on commit 1a33e60

Please sign in to comment.