Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDBF-588 Buildbot packages accessable in fixed repo URL per major ver… #192

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

grooverdan
Copy link
Member

…sion

first just is just a clean-up because scripts in long comments are hard. As you can see I haven't decided on a format. (partly hoping I've got py/shell escapes right).

May as well extend the patten to galera too. I'd use the url in the docker-library-build.sh.

@fauust
Copy link
Collaborator

fauust commented Oct 9, 2023

first just is just a clean-up because scripts in long comments are hard. As you can see I haven't decided on a format. (partly hoping I've got py/shell escapes right).

Can we sync and use a dedicated tool for that, I am having pretty good results with black. I don't know which IDE you use but in vim it's easy to install with vim-plug, and then just calling :Black in vim will do the job.

@fauust
Copy link
Collaborator

fauust commented Oct 9, 2023

Ok, maybe for the bash part, it's not so good. But then I would recommend we call shell script directly, in the long run it will be much more simple to maintain. Probably not for simple commands but I would say that if a snippets is more than 5 lines then it's worth it.

@grooverdan
Copy link
Member Author

black formatted, I do quite like the way the python is more readable.

Doesn't like bash it seems.

@grooverdan grooverdan changed the base branch from main to dev October 20, 2023 10:24
@grooverdan grooverdan force-pushed the galera-symlinks branch 4 times, most recently from 0cfb4a7 to c90b193 Compare October 20, 2023 11:04
@fauust
Copy link
Collaborator

fauust commented Oct 20, 2023

LGTM

@vladbogo vladbogo merged commit d9c8aca into MariaDB:dev Oct 20, 2023
3 checks passed
@grooverdan grooverdan deleted the galera-symlinks branch October 23, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants