Refactor locks.py #631
Open
Refactor locks.py #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvicentiu
force-pushed
the
refactor-2
branch
4 times, most recently
from
7b8f1a6 to
53168b9
Compare
1. Introduce a new yml file that stores worker locks counts. 2. Remove redundant and inconsistent naming between lock name and worker name.
RazvanLiviuVarzaru
requested changes
Nov 27, 2024
| # TODO: re-evaluate if this is the right place after multi-master | ||
| # is refactored to use a single base master.cfg. | ||
| with open( | ||
| os.path.join(os.path.dirname(os.path.realpath(__file__)), "worker_locks.yaml"), |
There was a problem hiding this comment.
@cvicentiu Why not keep the locks in constants, like every constant?
So we avoid any additional files that hold constant values.
WORKER_LOCKS = {
"hz-bbw1-docker": 9,
"hz-bbw2-docker": 1,
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: I HAVE NOT TESTED THIS PR.