Cleanups to rpm/deb install upgrade scripts #644
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it more generic and expands the columnstore saving to the required information. * service logs * columnstore data dir (tar.bz2) * /tmp/columnstore_tmp_files (appended to log file) More information like the mariadb.service journal and coredumps are saved.
…te,verify}_structures These are handled by rpm/deb-install/upgrade.
the new packages in CI.
As we going be in set -e mode when this is called, the trap will handle the saving of the error information.
We are under set -e so the error saving routine is there.
replace pattern:
# comment about what we are doing that isn't in bb log
if something_might_go_wrong; then
log_err - it went wrong
(missing error capture)
exit 1
to:
bb_log_info "where testing this"
sometime_might_go_wrong
The something_might_go_wrong in the second step will trap
and have all the saving of the failure afterwards leaving
the user with the info of what was being tested to provide
the failure context.
echo $v | sudo xargs .. is a antipattern, just use bash arrays. Replace if test condition; then fail with just; test condition, and let +e handle it. Rather than set -u /+u give ID_LIKE a default value so it won't error or match suse when its blank.
As script comments don't show when running make the output more readable.
There was no need for subshell, and to make shellcheck happy do the glob to arrays.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #607 , so from "rpm-install: use save_failure_logs trap" is new.