-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MDBF 135 - Don't run S3 for 10.5 / Use non-protected builders / Use SSL verification #663
MDBF 135 - Don't run S3 for 10.5 / Use non-protected builders / Use SSL verification #663
Conversation
S3 tests should run regardless of the previous testing suite outcome (green/red). The bucket creation was skipped when previous tests failed causes the main S3 suite to fail in the absence of a bucket. The only condition for the tests to be able to run is that the compile step is GREEN (compile_step_completed)
It looks like SSL Verify = NO doesn't work for 10.5 https://buildbot.mariadb.org/#/builders/369/builds/26765/steps/13/logs/stdio Will disable S3 tests until we figure it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets just disable for 10.5/10.6 (because there was an easy function) as I assume the rest is functional.
--- a/utils.py
+++ b/utils.py
@@ -570,6 +570,8 @@ def hasGalera(props):
def hasS3(props):
builderName = str(props.getProperty("buildername"))
+ if !filterBranch(props):
+ return False
for b in builders_s3_mtr:
if builderName in b:
return True
@grooverdan 10.6 should be working, for 10.5 indeed we shouldn't run for now. Setting it to V1 will allow using the hostname instead of IP and SSL verification will work. I can reintroduce the builders but I suggest using a non-protected one for a while, let's say aarch64-ubuntu-2004-debug instead of the amd64 counterpart. |
S3 tests don't work for 10.5 (SSL No verify option is not present).
https://buildbot.mariadb.org/#/builders/369/builds/26765/steps/13/logs/stdio
Added
alwaysRun
option oncreate bucket step
for the situation in which the previous test suite fails.I've manually disabled these tests on PROD also until further notice.
I suggest we do the buildbot migration and then come back on this subject.