Skip to content

Commit

Permalink
fix
Browse files Browse the repository at this point in the history
  • Loading branch information
Martinsos committed Sep 3, 2024
1 parent 7ccfcae commit b308074
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 20 deletions.
24 changes: 5 additions & 19 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,25 +15,11 @@ jobs:
name: "Check that CPP edlib correctly builds and passes tests."
strategy:
matrix:
include:
- os: ubuntu-20.04
- compiler:
- { package: gcc-10, cc: gcc-10, cxx: g++-10 }
- os: ubuntu-20.04
- compiler:
- { package: clang-11, cc: clang-11, cxx: clang++-11 }
- os: ubuntu-22.04
- compiler:
- { package: gcc-11, cc: gcc-11, cxx: g++-11 }
- os: ubuntu-22.04
- compiler:
- { package: clang-15, cc: clang-15, cxx: clang++-15 }
- os: macos-12
- compiler:
- { package: clang-11, cc: clang-11, cxx: clang++-11 }
- os: macos-14
- compiler:
- { package: clang-15, cc: clang-15, cxx: clang++-15 }
# TODO: add some older combos also?
os: [ubuntu-22.04, macos-14]
compiler:
- { package: gcc-11, cc: gcc-11, cxx: g++-11 }
- { package: clang-15, cc: clang-15, cxx: clang++-15 }
runs-on: ${{ matrix.os }}
steps:
- name: Checkout code
Expand Down
2 changes: 1 addition & 1 deletion bindings/python/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ wheels: sdist
# TODO: Try using older ubuntu/mac on CI to build wheels, maybe that helps, and then I don't need to set newer manylinux here?
# Default manylinux image is 2014 but it is quite old and won't build
# so I explicitly specify a newer version.
CIBW_MANYLINUX_X86_64_IMAGE=manylinux_2_28 \
# CIBW_MANYLINUX_X86_64_IMAGE=manylinux_2_28 \
# TODO: I was producing wheels for musllinux before! Why doesn't it work anymore?
# Is it possible that `make sdist` is issue?
# Or maybe it works in Github Actions? Yeah, try it there, maybe musl works there.
Expand Down

0 comments on commit b308074

Please sign in to comment.