This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
pyQT5 support added #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python pyQT5 version supported
|
but there is a problem with 3D simulation of the drone |
Marxlp
suggested changes
Sep 5, 2018
| @@ -13,6 +13,9 @@ | |||
| from pyulog.core import ULog | |||
| from pyqtgraph.Qt import QtCore,QtGui | |||
| import pyqtgraph as pg | |||
| from matplotlib.backends.backend_qt5agg import FigureCanvasQTAgg as FigureCanvas | |||
There was a problem hiding this comment.
You add this, but it seems that you didn't use it.
|
The log seems to work after i reinstalled it. But now the gui for 3d
representation doesnt seems to work.
…On Wed, Sep 5, 2018, 6:28 PM LP ***@***.***> wrote:
***@***.**** requested changes on this pull request.
After reading you pull request, I think the list operation you add on the
map function is needed. But I can't figure out what's the purpose of others
changes like importing FigureCanvas.
------------------------------
In src/analysis.py
<#11 (comment)>
:
> @@ -13,6 +13,9 @@
from pyulog.core import ULog
from pyqtgraph.Qt import QtCore,QtGui
import pyqtgraph as pg
+from matplotlib.backends.backend_qt5agg import FigureCanvasQTAgg as FigureCanvas
You add this, but it seems that you didn't use it.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#11 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AYJPVMe0EC3YVrzskBcPmNnaJaEjwXs6ks5uX8pggaJpZM4WJXU6>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python pyQT5 version supported