-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.X] Add logging
feature
#718
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
great feature and great code looks awesome💥 |
girardinsamuel
added
the
Next Minor
Non-breaking change that can go into the next minor version
label
Oct 13, 2022
Nice work @girardinsamuel This looks exactly like what I was getting at in #663. Keep up the great work. |
girardinsamuel
added
Next Major Only
and removed
Next Minor
Non-breaking change that can go into the next minor version
labels
Oct 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #663.
Specifications
Available drivers are:
terminal
,single
,daily
,syslog
,slack
.Logging configuration is done in
config/logging.py
Actually Sentry can be used in two different ways. One can add a custom exception handler and use sentry python binding to send the info or there could be a Sentry logging driver, but it would not do much more than the python sentry binding. So what I propose is to maybe create a package for integrating a sentry exception handler a bit like sentry-laravel.
What's left to do
syslog
,slack
drivers.propagate
optionlogging
feature docs#221