Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge should preserve zero value in dest #399

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

huww98
Copy link

@huww98 huww98 commented May 13, 2024

Fixes: #255

42atomys added a commit to go-sprout/sprout that referenced this pull request May 15, 2024
## Description
Backport fix of sprig into sprout, initially provided by @huww98

## Fixes Masterminds/sprig#255
Masterminds/sprig#399

## Checklist
- [x] I have read the **CONTRIBUTING.md** document.
- [x] My code follows the code style of this project.
- [x] I have added tests to cover my changes.
- [x] All new and existing tests passed.
- [x] I have updated the documentation accordingly.
- [ ] This change requires a change to the documentation on the website.

Co-authored-by: 胡玮文 <[email protected]>
@42atomys
Copy link

Hello @huww98 👋,

I wanted to let you know that this issue has been addressed in the fork of this project at go-sprout/sprout. The fix has been implemented starting from version v0.4.0.

For those looking for a solution, I recommend checking out the latest releases of the fork. This should help address the issue discussed in this thread.

Thank you for your contribution, you are added to the commit on sprout side as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merging with zero 0 does not work
2 participants