More on patterns overhaul (#1110)

This PR includes many tiny changes over mathics.core.pattern and mathics.builtin.patterns. * following @cory 's ExpReduce, the match method now has a `pattern_context` parameter that collects all the parameters. The linter seems to be happier with this change. * More annotations * More docstrings * More on avoiding the use of Python's built-in functions as identifiers. * `Rule` and `RuleDelayed` now check if they receive two parameters. If they receive more or less parameters, show a warning message. The work is not complete but is closer to being: it remains to remove `**kwargs` from the match calls, as well as some other adjustments. --------- Co-authored-by: rocky <[email protected]> Co-authored-by: R. Bernstein <[email protected]>
Mathics3 · Oct 3, 2024 · 9cc2331 · 9cc2331
1 parent 6860e5c
commit 9cc2331
Show file tree

Hide file tree

Showing 8 changed files with 633 additions and 529 deletions.
diff --git a/mathics/builtin/list/constructing.py b/mathics/builtin/list/constructing.py
@@ -439,7 +439,7 @@ def eval(self, expr, patterns, f, evaluation: Evaluation):
         def listener(e, tag):
             result = False
             for pattern, items in sown:
-                if pattern.does_match(tag, evaluation):
+                if pattern.does_match(tag, {"evaluation": evaluation}):
                     for item in items:
                         if item[0].sameQ(tag):
                             item[1].append(e)