Two postponed TODOs in recent PRs... #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rocky
commented
Oct 27, 2024
rocky
commented
- Move eval functions to mathics.eval.numbers.numbers
- Move "no_doc" after imports
* Move eval functions to mathics.eval.numbers.numbers * Move "no_doc" after imports
rocky
force-pushed
the
two-todos-from-other-PRs
branch
from
b818ecd
to
a35c843
Compare
mmatera
reviewed
Oct 27, 2024
| @@ -140,25 +222,11 @@ def cancel(expr): | |||
| return expr | |||
|
|
|||
|
|
|||
| def cancel(expr): | |||
There was a problem hiding this comment.
What happens with this function? Is it not needed anymore?
There was a problem hiding this comment.
The function is duplicated. This is easier to see in the master branch right now:
https://github.com/Mathics3/mathics-core/blob/master/mathics/eval/numbers/numbers.py#L122-L149
There was a problem hiding this comment.
Thanks for the clarification!
mmatera
approved these changes
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.