Redo TraceEvaluation using a decorator... #1169
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocky
force-pushed
the
redo-TraceEvaluation-with-hooks
branch
from
a9e4f29
to
c5fe121
Compare
rocky
force-pushed
the
redo-TraceEvaluation-with-hooks
branch
2 times, most recently
from
35a69ec
to
90bc0eb
Compare
rocky
commented
Nov 17, 2024
mathics/builtin/trace.py
Outdated
| >> TraceEvaluation[(x + x)^2] | ||
| The 'ShowTimeBySteps' option prints the elapsed time before an evaluation occurs. | ||
|
|
||
| >> TraceEvaluation[(x + 1)^2] |
There was a problem hiding this comment.
Note this gives less verbose trace output since we don't have to look up x again.
There was a problem hiding this comment.
Actually, using x + x is nicer in that it shows symbolic interpretation. So the example has been reinstated. Still I feel that TraceEvaluation is not as informative as it could be and it is showing useless information.
I mention some of this in https://github.com/Mathics3/mathics3-debugger/tree/TraceEvaluation-event-hooks?tab=readme-ov-file#improved-traceevaluation and at some point possibly the additional code that appears there may wind its way back to core. But I think that should happen only after we use this a bit and things and the desired behavior feels right.
This also allows the external debugger to do a much better job of this
rocky
force-pushed
the
redo-TraceEvaluation-with-hooks
branch
from
3cb714a
to
68b0109
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also allows the external debugger to do a much better job of this. See this discussion for an example of using.