Add setup.py #1
Add setup.py #1
Conversation
setup.py
Outdated
| name="Mathics-doctest", | ||
| version="0.1.0", | ||
| install_requires=[ | ||
| "Mathics3 >= 4.0.0" |
There was a problem hiding this comment.
We don't want to install Mathics3 at all. This would cause a circular dependency since mathics-core needs this.
In CI for full testing it can import mathics-core, but is that is not a setup dependency.
And locally and in CI for unit testing, data from core as it is can be pulled in here. Some sort skeletal builtin modules can be created in a test directory.
But for to get started we can just try this without any tests.
There was a problem hiding this comment.
We also probably need a packages attribute in the setup to declare the module.
There was a problem hiding this comment.
In CI for full testing it can import mathics-core, but is that is not a setup dependency.
Is it going to be done through just download or submodule? (I think the 1st is better in this case).
There was a problem hiding this comment.
As you suspect, download is simpler.
TiagoCavalcante
force-pushed
the
add-setup.py
branch
from
2c92604
to
ccbd0b7
Compare
| import sys | ||
|
|
||
| python_version = sys.version_info[:2] | ||
| if python_version < (3, 6): |
There was a problem hiding this comment.
We support 3.6 in mathics-core right?
What in 3.7 do we need?
There was a problem hiding this comment.
Ooops. this refers to the error message below.
Probably it needs to be fixed in mathics-core as well.
TiagoCavalcante
force-pushed
the
add-setup.py
branch
from
ccbd0b7
to
74c965b
Compare
No description provided.