Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exprimental Mathics3 Module Guide section #19

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Exprimental Mathics3 Module Guide section #19

wants to merge 2 commits into from

Conversation

rocky
Copy link
Member

@rocky rocky commented Apr 4, 2024

No description provided.

@rocky rocky requested a review from mmatera April 4, 2024 16:25
@rocky rocky marked this pull request as draft April 4, 2024 16:25
mmatera
mmatera reviewed Apr 4, 2024
View reviewed changes
pymathics/natlang/linguistic_data/lang_trans.py Outdated
@@ -0,0 +1,3 @@
"""
Languages & Translaations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@mmatera
Copy link
Contributor

mmatera commented Apr 7, 2024

@rocky, I looked at the problem with this PR. The problem is not in the documentation, (except a detail with an import #20) but with the module loading mechanism: mathics.eval.pymathics.load_pymathics_modules does not load the submodules recursively. I will try to fix it later today.

@mmatera mmatera mentioned this pull request Apr 7, 2024
Merged
@mmatera
fix import in test (#20)
dd7d68d 
* fix import in test
* fixing osx workflow
rocky pushed a commit to Mathics3/mathics-core that referenced this pull request Aug 5, 2024
@mmatera
fixes required for deeper pymathics modules (#1031)
64ca65d 
This PR seems to fix the issue with Pymathics Natlang documentation
(Mathics3/pymathics-natlang#19 (comment))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmatera mmatera mmatera left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rocky @mmatera