Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added errMsgId parameter to FingerprintAuthenticationException #89

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

o-vitaliy
Copy link

Added errMsgId to be able to filter exceptions which are not have to be handled

@Mauin
Copy link
Owner

Mauin commented Mar 16, 2018

I'd be interested to hear which kind of errors you want to filter? What is the use case?

@o-vitaliy
Copy link
Author

I have several use cases
In the first case an authentication is available only while a dialog is shown. When user closes the dialog, I call fingerprintDisposable.dispose() and I get exception FINGERPRINT_ERROR_CANCELED in onError callback. I don't what to give any feedback to user when authentication is canceled, and I want to skip this exception.

And in the second case when I get FINGERPRINT_ERROR_LOCKOUT I have to offer to user other way to sign in in the application

@Mauin
Copy link
Owner

Mauin commented Mar 19, 2018

Interesting. It might make sense including the errMsgId in the Exception, however:

  • I'm currently not seeing the FINGERPRINT_ERROR_CANCELED message in onError when cancelling the fingerprint operation by calling .dispose(). Which version of RxFingerprint are you currently using?
  • The user should always have the ability to fall back to another way of signing into the application as defined by Google's guidelines.

@LosDanieloss
Copy link

It's been some time since the last activity in this PR. Can or maybe when can we expect a new version with this change? It would have been a pretty useful addition.

@TerryJung
Copy link

is there any changed ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants