Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve performance #41

Merged
merged 3 commits into from
Sep 13, 2023
Merged

improve performance #41

merged 3 commits into from
Sep 13, 2023

Conversation

BillyDM
Copy link

@BillyDM BillyDM commented Aug 22, 2023

  • Removed the unnecessary interleaving/deinterleaving steps in the Symphonia decoder. Symphonia already has its buffers in deinterleaved form, so removing this should improve performance.
  • Improved the interleaving performance in the WAV writer. Before the compiler wasn't using any SIMD optimizations, but now it is.

@BillyDM BillyDM requested review from uklotzde and orottier September 1, 2023 19:40
orottier
orottier approved these changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@orottier orottier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

encode_wav/src/lib.rs Show resolved Hide resolved
@BillyDM BillyDM merged commit 7a1a5e4 into main Sep 13, 2023
4 checks passed
@BillyDM BillyDM deleted the improve-performance branch January 2, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orottier orottier orottier approved these changes

@uklotzde uklotzde Awaiting requested review from uklotzde

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BillyDM @orottier