Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

Stage Release to TEST #2178

Merged
merged 21 commits into from
Sep 27, 2023
Merged

Stage Release to TEST #2178

merged 21 commits into from
Sep 27, 2023

Conversation

jkotanchik-SB
Copy link
Contributor

Pull requests into Bonnie require the following. Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable ("N/A") and ✅.

Submitter:

  • This pull request describes why these changes were made.
  • This PR is into the correct branch.
  • JIRA ticket for this PR:
  • JIRA ticket links to this PR
  • Code diff has been done and been reviewed (it does not contain: additional white space, not applicable code changes, debug statements, etc.)
  • If UI changes have been made, google WAVE plug-in has been executed to ensure no 508 issues were introduced.
  • Tests are included and test edge cases
  • Tests have been run locally and pass (remember to update Gemfile when applicable)
  • Test fixtures updated and documented as necessary ( see internal wiki )
  • Code coverage has not gone down and all code touched or added is covered.
    • In rare situations, this may not be possible or applicable to a PR. In those situations:
      1. Note why this could not be done or is not applicable here:
      2. Add TODOs in the code noting that it requires a test
      3. Add a JIRA task to add the test and link it here:
  • Automated regression test(s) pass

If JIRA tests were used to supplement or replace automated tests:

  • JIRA test links:
  • Justification for using JIRA tests:
  • JIRA tests have been added to sprint

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases

If JIRA tests were used to supplement or replace automated tests:

  • JIRA tests have been run and pass
  • You agree with the justification for use of JIRA tests or have provided input on why you disagree

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

If JIRA tests were used to supplement or replace automated tests:

  • JIRA tests have been run and pass
  • You agree with the justification for use of JIRA tests or have provided input on why you disagree

adongare and others added 20 commits July 14, 2022 15:29
* MAT-5709 use cqm-execution v4.1.2

* fix minimatch vulnerability

* MAT-5415 add facility location attribute support
* MAT-5709 use cqm-execution v4.1.2

* fix minimatch vulnerability

* MAT-5415 add facility location attribute support

* MAT-3982 Bonnie - Incorrect display results for a CQL aggregate functions
MAT-5759, MAT-5709 is operator support & cqm-execution/model updates

* use cqm-execution v4.1.3

* commit change to trigger build
* MAT-5859 Bonnie - Update Test Case List UI for Observations

* remove debug statement

* MAT-5859 fix test case

* MAT-5859 test case fix

* MAT-5859 refactoring

* bump version to v5.1.4

* MAT-5859 more refactoring

* MAT-5859 test cases
MAT-5993 remove OBSERV for ratio patients

* MAT-5859 code review

* trigger the build
…2161)

* MAT-5993 ratio observation migration script

* MAT-5860 added couple more test cases for ratio measures actual vs expected values

* MAT-5860 removed unwanted code

* MAT-5993 Ratio patient excel Export issues

* MAT-5993 ratio patient delete OBSERV

* more test cases

* MAT-5859 remove unit switch
* update user guide for v5.1.4

* update user guide for v5.1.4
…ey. Replace TGT/ST related parameters with API Key. Consider a UMLS session invalid when an authenticated request (using the API Key) returns 401 instead of checking for TGT/ST generation.
Remove explicit npm install. Latest npm incompatible with node 16.
…ddl-logging

[MAT-6104] Additional Logging Around Measure Create/Update
…r-version

Increment Bonnie Proper version to 5.1.5
@jkotanchik-SB jkotanchik-SB merged commit 809348e into staging Sep 27, 2023
31 of 34 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants