Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

Stage Bonnie Prior to TEST #2182

Merged
merged 9 commits into from
Sep 28, 2023
Merged

Stage Bonnie Prior to TEST #2182

merged 9 commits into from
Sep 28, 2023

Conversation

jkotanchik-SB
Copy link
Contributor

Pull requests into Bonnie require the following. Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable ("N/A") and ✅.

Submitter:

  • This pull request describes why these changes were made.
  • This PR is into the correct branch.
  • JIRA ticket for this PR:
  • JIRA ticket links to this PR
  • Code diff has been done and been reviewed (it does not contain: additional white space, not applicable code changes, debug statements, etc.)
  • If UI changes have been made, google WAVE plug-in has been executed to ensure no 508 issues were introduced.
  • Tests are included and test edge cases
  • Tests have been run locally and pass (remember to update Gemfile when applicable)
  • Test fixtures updated and documented as necessary ( see internal wiki )
  • Code coverage has not gone down and all code touched or added is covered.
    • In rare situations, this may not be possible or applicable to a PR. In those situations:
      1. Note why this could not be done or is not applicable here:
      2. Add TODOs in the code noting that it requires a test
      3. Add a JIRA task to add the test and link it here:
  • Automated regression test(s) pass

If JIRA tests were used to supplement or replace automated tests:

  • JIRA test links:
  • Justification for using JIRA tests:
  • JIRA tests have been added to sprint

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases

If JIRA tests were used to supplement or replace automated tests:

  • JIRA tests have been run and pass
  • You agree with the justification for use of JIRA tests or have provided input on why you disagree

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

If JIRA tests were used to supplement or replace automated tests:

  • JIRA tests have been run and pass
  • You agree with the justification for use of JIRA tests or have provided input on why you disagree

jkotanchik-SB and others added 8 commits September 13, 2023 15:42
…I Key. Replace TGT check with retrieval of the ONC Admin Sex valueset, since it's a default VS added by the MAT and contains two codes.
…pdate-vsac-connection-prior

[MAT-6046] Replace TGT/ST with UMLS API Key in VSAC Requests - Prior
…-cred-timeout-prior

Remove VSAC Cred Timeout
…-version

Increment Bonnie prior version to 4.3.2
@jkotanchik-SB jkotanchik-SB requested a review from a team September 28, 2023 16:09
@jkotanchik-SB jkotanchik-SB self-assigned this Sep 28, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #2182 (30f561a) into prior-staging (b9020b1) will decrease coverage by 3.09%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           prior-staging    #2182      +/-   ##
=================================================
- Coverage          76.59%   73.50%   -3.09%     
=================================================
  Files                139       83      -56     
  Lines               8344     5952    -2392     
  Branches             809      809              
=================================================
- Hits                6391     4375    -2016     
+ Misses              1637     1261     -376     
  Partials             316      316              
Files Coverage Δ
...ts/javascripts/views/import_measure_view.js.coffee 76.28% <ø> (+0.96%) ⬆️

... and 57 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9020b1...30f561a. Read the comment docs.

@jkotanchik-SB jkotanchik-SB merged commit ed9d33a into prior-staging Sep 28, 2023
32 of 36 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants