Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

merge master to stage for v5.1.5 release #2193

Merged
merged 2 commits into from
Nov 22, 2023
Merged

merge master to stage for v5.1.5 release #2193

merged 2 commits into from
Nov 22, 2023

Conversation

adongare
Copy link
Contributor

  • MAT-6385 Bonnie Test Case Coverage Drop to 98%- CMS161 pull cqm-execution v4.1.4

  • remove unwanted links to external repos

Pull requests into Bonnie require the following. Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable ("N/A") and ✅.

Submitter:

  • This pull request describes why these changes were made.
  • This PR is into the correct branch.
  • JIRA ticket for this PR:
  • JIRA ticket links to this PR
  • Code diff has been done and been reviewed (it does not contain: additional white space, not applicable code changes, debug statements, etc.)
  • If UI changes have been made, google WAVE plug-in has been executed to ensure no 508 issues were introduced.
  • Tests are included and test edge cases
  • Tests have been run locally and pass (remember to update Gemfile when applicable)
  • Code coverage has not gone down and all code touched or added is covered.
    • In rare situations, this may not be possible or applicable to a PR. In those situations:
      1. Note why this could not be done or is not applicable here:
      2. Add TODOs in the code noting that it requires a test
      3. Add a JIRA task to add the test and link it here:
  • Automated regression test(s) pass

If JIRA tests were used to supplement or replace automated tests:

  • JIRA test links:
  • Justification for using JIRA tests:
  • JIRA tests have been added to sprint

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases

If JIRA tests were used to supplement or replace automated tests:

  • JIRA tests have been run and pass
  • You agree with the justification for use of JIRA tests or have provided input on why you disagree

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

If JIRA tests were used to supplement or replace automated tests:

  • JIRA tests have been run and pass
  • You agree with the justification for use of JIRA tests or have provided input on why you disagree

* MAT-6385 Bonnie Test Case Coverage Drop to 98%- CMS161
pull cqm-execution v4.1.4

* remove unwanted links to external repos
@adongare adongare marked this pull request as ready for review November 22, 2023 15:45
@adongare adongare changed the title MAT-6385 Bonnie Test Case Coverage Drop to 98%- CMS161 (#2192) merge master to stage for v5.1.5 release Nov 22, 2023
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #2193 (8536197) into staging (376692b) will not change coverage.
Report is 2 commits behind head on staging.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           staging    #2193   +/-   ##
========================================
  Coverage    71.46%   71.46%           
========================================
  Files           87       87           
  Lines         6293     6293           
  Branches       884      884           
========================================
  Hits          4497     4497           
  Misses        1454     1454           
  Partials       342      342           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 376692b...8536197. Read the comment docs.

@sb-bdonohue sb-bdonohue merged commit 03923d1 into staging Nov 22, 2023
37 of 40 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants