Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-7060 library usage API, delete library API #80

Merged
merged 22 commits into from
Aug 7, 2024
Merged

Conversation

adongare
Copy link
Contributor

@adongare adongare commented Aug 2, 2024

MADiE PR

Jira Ticket: MAT-7060
(Optional) Related Tickets:

Summary

  • API to fetch all the libraries that include this library in
  • Introduced active library flag and changelog to migrate all the libraries to mark as active by default. we don't want to consider inactive libraries.
  • Introduced a includedLibraries model property to store included library details and its changelog
  • API to Delete library and its versions if none of the versions is being used either in another library or measure

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included and Code coverage is verified.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@adongare adongare changed the title MAT-7060 MAT-7060 library usage API Aug 4, 2024
@adongare adongare changed the title MAT-7060 library usage API MAT-7060 library usage API- libraries only Aug 5, 2024
@adongare adongare marked this pull request as ready for review August 5, 2024 16:19
@adongare adongare requested a review from a team as a code owner August 5, 2024 16:19
sb-cecilialiu
sb-cecilialiu previously approved these changes Aug 6, 2024
@adongare adongare changed the title MAT-7060 library usage API- libraries only MAT-7060 library usage API, delete library API Aug 6, 2024
@adongare adongare requested a review from sb-cecilialiu August 6, 2024 15:29
sb-cecilialiu
sb-cecilialiu previously approved these changes Aug 6, 2024
Copy link
Contributor

@sb-cecilialiu sb-cecilialiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be good if some common objects and utils can be in one place, but for now changes look good!

@adongare
Copy link
Contributor Author

adongare commented Aug 6, 2024

@sb-cecilialiu moved dto to models. I'll move utils method to madie-rest-commons probably?

@sb-cecilialiu
Copy link
Contributor

@sb-cecilialiu moved dto to models. I'll move utils method to madie-rest-commons probably?

Thanks so much, madie-rest-commons sounds good, but it's ok if you leave them here :)

@adongare adongare merged commit 4e09367 into develop Aug 7, 2024
7 checks passed
@adongare adongare deleted the MAT-7060 branch August 7, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants