Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-7723: Bug fixes in Libraries CQL editor #165

Merged
merged 3 commits into from
Nov 6, 2024
Merged

MAT-7723: Bug fixes in Libraries CQL editor #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a63491
fix bug where the vertical scrollbar is not appearing
etan-sb Nov 6, 2024
cef667f
fix bug where the 'Indicates required field' element would be overlap…
etan-sb Nov 6, 2024
6b8eafc
fix prettier formatting
etan-sb Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/components/editCqlLibrary/EditCQLLibrary.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,10 @@
height: 700px;

.left-panel {
width: 75%;
overflow: hidden;
> div {
height: calc(100% - 40px);
overflow: auto;
}

> .panel-content {
padding-top: 32px;
Expand All @@ -81,7 +83,6 @@
}

.right-panel {
width: 25%;
margin-left: 12px;

> .panel-content {
Expand Down
1 change: 0 additions & 1 deletion src/components/editCqlLibrary/EditCqlLibrary.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@
setErrorMessage("An error occurred while fetching the CQL Library!");
});
}
}, [id, resetForm, loadedCqlLibrary, cqlLibraryServiceApi]);

Check warning on line 176 in src/components/editCqlLibrary/EditCqlLibrary.tsx

View workflow job for this annotation

GitHub Actions / Checkout, install, lint, build and test with coverage 

React Hook useEffect has a missing dependency: 'handleAnnotations'. Either include it or remove the dependency array

// fetch organizations DB using measure service and sorts alphabetically
useEffect(() => {
Expand All @@ -189,7 +189,7 @@
const message = `Error fetching organizations`;
handleToast("danger", message, true);
});
}, []);

Check warning on line 192 in src/components/editCqlLibrary/EditCqlLibrary.tsx

View workflow job for this annotation

GitHub Actions / Checkout, install, lint, build and test with coverage 

React Hook useEffect has a missing dependency: 'organizationApi'. Either include it or remove the dependency array

async function updateCqlLibrary(cqlLibrary: CqlLibrary) {
setActiveSpinner(true);
Expand Down Expand Up @@ -394,7 +394,6 @@
/>
<div
style={{
marginBottom: -10,
marginTop: 10,
display: "flex",
flexDirection: "row",
Expand Down
Loading