Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Time Field Component to accept additional props, and enabled… #190

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

RohitKandimalla
Copy link
Contributor

… TimePicker

MADiE PR

Jira Ticket: MAT-5751
(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).
  • All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@RohitKandimalla RohitKandimalla self-assigned this Oct 5, 2023
@RohitKandimalla RohitKandimalla requested a review from a team as a code owner October 5, 2023 13:39
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #190 (614d62d) into main (cba8be3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #190   +/-   ##
=======================================
  Coverage   94.04%   94.04%           
=======================================
  Files          31       31           
  Lines         403      403           
  Branches      101      101           
=======================================
  Hits          379      379           
  Misses         12       12           
  Partials       12       12           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@RohitKandimalla RohitKandimalla merged commit 1e0d307 into main Oct 5, 2023
8 checks passed
@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (cba8be3) 324 313 96.61%
Head commit (614d62d) 324 (+0) 313 (+0) 96.61% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#190) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants