Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mat 7699 delete parameter #379

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Mat 7699 delete parameter #379

merged 4 commits into from
Nov 13, 2024

Conversation

sb-cecilialiu
Copy link
Contributor

@sb-cecilialiu sb-cecilialiu commented Nov 12, 2024

MADiE PR

Jira Ticket: MAT-7699
(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included
  • No extemporaneous files are included (i.e Complied files or testing results)
  • This PR is in to the correct branch.
  • All Documentation as needed for this PR is Complete (or noted in a TODO or other Ticket)
  • Any breaking changes or failing automation are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package)
  • All CDN/Web dependancies are hosted internally (i.e MADiE-Root Repo)

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads

@sb-cecilialiu sb-cecilialiu requested a review from a team as a code owner November 12, 2024 22:46
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.42%. Comparing base (cd66982) to head (5895569).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
src/CqlBuilderPanel/Parameters/SavedParameters.tsx 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #379      +/-   ##
===========================================
+ Coverage    84.29%   84.42%   +0.12%     
===========================================
  Files           62       62              
  Lines         1566     1579      +13     
  Branches       286      288       +2     
===========================================
+ Hits          1320     1333      +13     
  Misses         179      179              
  Partials        67       67              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sb-cecilialiu sb-cecilialiu merged commit 8604ac7 into develop Nov 13, 2024
13 checks passed
@sb-cecilialiu sb-cecilialiu deleted the MAT-7699_deleteParameter branch November 13, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants