Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-7872 second PR: setting loading to false when cql is empty #381

Merged
merged 2 commits into from
Nov 15, 2024
Merged

MAT-7872 second PR: setting loading to false when cql is empty #381

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0cbb1a
MAT-7872 setting loading to false when cql is empty
sb-prateekkeerthi Nov 15, 2024
0021b7c
Merge branch 'develop' into MAT-7872/displayingNoResultsFoundInSavedD…
sb-prateekkeerthi Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/CqlBuilderPanel/CqlBuilderPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,10 @@
setLoading(false);
});
}
} else {
setLoading(false);
}
}, [measureModel, measureStoreCql]);

Check warning on line 134 in src/CqlBuilderPanel/CqlBuilderPanel.tsx

View workflow job for this annotation

GitHub Actions / Checkout, install, lint, build and test with coverage 

React Hook useEffect has missing dependencies: 'fhirElmTranslationServiceApi' and 'qdmElmTranslationServiceApi'. Either include them or remove the dependency array

return (
<div className="right-panel">
Expand Down
Loading