Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-7652 CQL Validation - Multiple Using Statements #386

Merged
merged 9 commits into from
Dec 3, 2024
Merged

Conversation

adongare
Copy link
Contributor

MADiE PR

Jira Ticket: MAT-7652
(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included
  • No extemporaneous files are included (i.e Complied files or testing results)
  • This PR is in to the correct branch.
  • All Documentation as needed for this PR is Complete (or noted in a TODO or other Ticket)
  • Any breaking changes or failing automation are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package)
  • All CDN/Web dependancies are hosted internally (i.e MADiE-Root Repo)

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads

@adongare adongare marked this pull request as ready for review December 3, 2024 13:55
@adongare adongare requested a review from a team as a code owner December 3, 2024 13:55
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 83.60656% with 10 lines in your changes missing coverage. Please review.

Project coverage is 87.88%. Comparing base (de07798) to head (7dbcefe).
Report is 10 commits behind head on develop.

Files with missing lines Patch % Lines
src/AceEditor/madie-ace-editor.tsx 83.60% 6 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #386      +/-   ##
===========================================
+ Coverage    84.80%   87.88%   +3.07%     
===========================================
  Files           68       68              
  Lines         1593     1634      +41     
  Branches       298      305       +7     
===========================================
+ Hits          1351     1436      +85     
+ Misses         173      137      -36     
+ Partials        69       61       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sb-cecilialiu
sb-cecilialiu previously approved these changes Dec 3, 2024
src/AceEditor/madie-ace-editor.test.tsx Show resolved Hide resolved
src/AceEditor/madie-ace-editor.tsx Outdated Show resolved Hide resolved
@adongare adongare merged commit 4a8c0c4 into develop Dec 3, 2024
10 checks passed
@adongare adongare deleted the MAT-7652 branch December 3, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants