Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-7792, MAT-7793: Set up Functions - Expresion Edtior section #396

Merged
merged 9 commits into from
Dec 10, 2024

Conversation

mcmcphillips
Copy link
Contributor

@mcmcphillips mcmcphillips commented Dec 3, 2024

MADiE PR

Jira Ticket: MAT-7792
Jira Ticket: MAT-7793

(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included
  • No extemporaneous files are included (i.e Complied files or testing results)
  • This PR is in to the correct branch.
  • All Documentation as needed for this PR is Complete (or noted in a TODO or other Ticket)
  • Any breaking changes or failing automation are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package)
  • All CDN/Web dependancies are hosted internally (i.e MADiE-Root Repo)

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads

@mcmcphillips mcmcphillips requested a review from a team as a code owner December 3, 2024 19:31
@mcmcphillips mcmcphillips changed the title MAT-7792: Implement Function section MAT-7792: Set up Functions - Expresion Edtior section Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 98.24561% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.40%. Comparing base (50ce7e4) to head (81f2e15).
Report is 10 commits behind head on develop.

Files with missing lines Patch % Lines
...nctionsSection/functionBuilder/FunctionBuilder.tsx 95.23% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #396      +/-   ##
===========================================
+ Coverage    87.75%   88.40%   +0.65%     
===========================================
  Files           71       72       +1     
  Lines         1829     1855      +26     
  Branches       333      334       +1     
===========================================
+ Hits          1605     1640      +35     
+ Misses         157      150       -7     
+ Partials        67       65       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcmcphillips mcmcphillips force-pushed the MAT-7792 branch 2 times, most recently from 7e5339d to 38821fb Compare December 6, 2024 00:07
adongare
adongare previously approved these changes Dec 6, 2024
@mcmcphillips mcmcphillips changed the title MAT-7792: Set up Functions - Expresion Edtior section MAT-7792, MAT-7793: Set up Functions - Expresion Edtior section Dec 6, 2024
@mcmcphillips mcmcphillips requested review from adongare and a team December 6, 2024 23:24
chubert-sb
chubert-sb previously approved these changes Dec 9, 2024
RohitKandimalla
RohitKandimalla previously approved these changes Dec 9, 2024
Copy link
Contributor

@RohitKandimalla RohitKandimalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor observations, not necessarily have to be modified.

src/CqlBuilderPanel/common/utils.tsx Outdated Show resolved Hide resolved
src/CqlBuilderPanel/common/utils.tsx Show resolved Hide resolved
Copy link
Contributor

@sb-cecilialiu sb-cecilialiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mcmcphillips mcmcphillips merged commit 0c6b6ed into develop Dec 10, 2024
12 checks passed
@mcmcphillips mcmcphillips deleted the MAT-7792 branch December 10, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants