Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-7791: argument section #401

Merged
merged 9 commits into from
Dec 6, 2024
Merged

Conversation

chubert-sb
Copy link
Contributor

MADiE PR

Jira Ticket: MAT-7791
(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included
  • No extemporaneous files are included (i.e Complied files or testing results)
  • This PR is in to the correct branch.
  • All Documentation as needed for this PR is Complete (or noted in a TODO or other Ticket)
  • Any breaking changes or failing automation are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package)
  • All CDN/Web dependancies are hosted internally (i.e MADiE-Root Repo)

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads

@chubert-sb chubert-sb requested a review from a team as a code owner December 6, 2024 18:08
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 54.80769% with 47 lines in your changes missing coverage. Please review.

Project coverage is 86.62%. Comparing base (a21d3f4) to head (aa68b85).
Report is 10 commits behind head on develop.

Files with missing lines Patch % Lines
...nel/functionsSection/argumentSection/Arguments.tsx 49.27% 31 Missing and 4 partials ⚠️
...nctionsSection/argumentSection/ArgumentSection.tsx 73.07% 7 Missing ⚠️
...nctionsSection/functionBuilder/FunctionBuilder.tsx 37.50% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #401      +/-   ##
===========================================
- Coverage    88.54%   86.62%   -1.93%     
===========================================
  Files           68       71       +3     
  Lines         1720     1824     +104     
  Branches       322      332      +10     
===========================================
+ Hits          1523     1580      +57     
- Misses         134      177      +43     
- Partials        63       67       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcmcphillips mcmcphillips merged commit ac5c792 into develop Dec 6, 2024
11 of 13 checks passed
@mcmcphillips mcmcphillips deleted the feature/MAT-7791-argument-section branch December 6, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants