Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-7246 QDM - Remove Value Set Versions from CQL and notify user #564

Merged
merged 4 commits into from
Jun 21, 2024

Conversation

adongare
Copy link
Contributor

@adongare adongare commented Jun 18, 2024

MAT-7246 QDM - Remove Value Set Versions from CQL and notify user, refactored status handler

MADiE PR

Jira Ticket: MAT-7246
(Optional) Related Tickets:
related PR: MeasureAuthoringTool/madie-cql-library#146

Summary

  • Value set with version will be reverted
  • Generic message that was being shown earlier for library statement and using statement is split into separate messages

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).
  • All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.
Screen.Recording.2024-06-20.at.8.50.45.AM.mov

@adongare adongare requested a review from a team as a code owner June 18, 2024 21:37
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.36%. Comparing base (3165486) to head (d009503).
Report is 7 commits behind head on develop.

Current head d009503 differs from pull request most recent head 02b7c31

Please upload reports for the commit 02b7c31 to get more accurate results.

Files Patch % Lines
...rc/components/editMeasure/editor/MeasureEditor.tsx 73.33% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #564      +/-   ##
===========================================
- Coverage    86.45%   86.36%   -0.09%     
===========================================
  Files           75       75              
  Lines         3100     3103       +3     
  Branches       670      669       -1     
===========================================
  Hits          2680     2680              
- Misses         269      270       +1     
- Partials       151      153       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adongare adongare merged commit 18ca109 into develop Jun 21, 2024
10 of 11 checks passed
@adongare adongare deleted the MAT-7246 branch June 21, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants