Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drc data criteria #101

Merged
merged 6 commits into from
Oct 11, 2023
Merged

Drc data criteria #101

merged 6 commits into from
Oct 11, 2023

Conversation

sb-cecilialiu
Copy link
Contributor

@sb-cecilialiu sb-cecilialiu commented Oct 9, 2023

CQL to ELM Translation Service PR

Jira Ticket: MAT-6210
(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@sb-cecilialiu sb-cecilialiu requested a review from a team as a code owner October 9, 2023 15:16
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #101 (d18e8e9) into develop (99d99bb) will decrease coverage by 0.15%.
The diff coverage is 92.30%.

@@             Coverage Diff             @@
##           develop     #101      +/-   ##
===========================================
- Coverage    71.27%   71.12%   -0.15%     
===========================================
  Files           52       52              
  Lines         1911     1905       -6     
  Branches       182      182              
===========================================
- Hits          1362     1355       -7     
- Misses         455      456       +1     
  Partials        94       94              
Files Coverage Δ
...at/cql_elm_translation/dto/SourceDataCriteria.java 87.50% <100.00%> (+1.78%) ⬆️
...l_elm_translation/service/DataCriteriaService.java 88.33% <100.00%> (+0.09%) ⬆️
...ation/service/EffectiveDataRequirementService.java 100.00% <100.00%> (ø)
...ms/mat/cql_elm_translation/utils/cql/CQLTools.java 58.49% <100.00%> (-0.97%) ⬇️
...translation/utils/cql/parsing/Cql2ElmListener.java 44.26% <90.00%> (-0.83%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@adongare adongare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sb-cecilialiu sb-cecilialiu merged commit f096bbe into develop Oct 11, 2023
4 of 5 checks passed
@sb-cecilialiu sb-cecilialiu deleted the drc-data-criteria branch October 11, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants