Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-6212: Add check for direct data reference codes #104

Merged
merged 3 commits into from
Oct 17, 2023

Conversation

chubert-sb
Copy link
Contributor

CQL to ELM Translation Service PR

Jira Ticket: MAT-6212
(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@chubert-sb chubert-sb requested a review from a team as a code owner October 13, 2023 15:36
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #104 (d044206) into develop (90fb82d) will decrease coverage by 0.43%.
The diff coverage is 100.00%.

❗ Current head d044206 differs from pull request most recent head 27f8a62. Consider uploading reports for the commit 27f8a62 to get more accurate results

@@             Coverage Diff             @@
##           develop     #104      +/-   ##
===========================================
- Coverage    71.58%   71.15%   -0.43%     
===========================================
  Files           52       52              
  Lines         1925     1907      -18     
  Branches       183      182       -1     
===========================================
- Hits          1378     1357      -21     
- Misses         452      456       +4     
+ Partials        95       94       -1     
Files Coverage Δ
...l_elm_translation/service/DataCriteriaService.java 88.52% <100.00%> (ø)

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

sb-cecilialiu
sb-cecilialiu previously approved these changes Oct 16, 2023
@chubert-sb chubert-sb merged commit c0d2e0a into develop Oct 17, 2023
3 checks passed
@chubert-sb chubert-sb deleted the feature/MAT-6212-data-element-reference-codes branch October 17, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants