MAT-6224 PR feedback

MeasureAuthoringTool · Feb 29, 2024 · 2298a2c · 2298a2c
1 parent 0182e66
commit 2298a2c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 25 deletions.
diff --git a/src/main/java/gov/cms/madie/services/HqmfService.java b/src/main/java/gov/cms/madie/services/HqmfService.java
@@ -5,7 +5,6 @@
 import gov.cms.madie.hqmf.HQMFGeneratorFactory;
 import gov.cms.madie.hqmf.dto.MeasureExport;
 import gov.cms.madie.models.measure.QdmMeasure;
-import jakarta.xml.bind.JAXBException;
 import lombok.AllArgsConstructor;
 import lombok.extern.slf4j.Slf4j;
 import org.springframework.stereotype.Service;
@@ -22,15 +21,7 @@ public String generateHqmf(QdmMeasure qdmMeasure) {
     String simpleXml;
     try {
       simpleXml = simpleXmlService.measureToSimpleXml(qdmMeasure);
-    } catch (JAXBException ex) {
-      String message =
-          "An issue occurred while generating the simple xml for measure: " + qdmMeasure.getId();
-      log.error(message, ex);
-      throw new PackagingException(message, ex);
-    }
-
-    Generator hqmfGenerator = hqmfGeneratorFactory.getHQMFGenerator();
-    try {
+      Generator hqmfGenerator = hqmfGeneratorFactory.getHQMFGenerator();
       MeasureExport measureExport =
           MeasureExport.builder().measure(qdmMeasure).simpleXml(simpleXml).build();
       return hqmfGenerator.generate(measureExport);

diff --git a/src/test/java/gov/cms/madie/services/HqmfServiceTest.java b/src/test/java/gov/cms/madie/services/HqmfServiceTest.java
@@ -6,7 +6,6 @@
 import gov.cms.madie.hqmf.qdm_5_6.HQMFGenerator;
 import gov.cms.madie.models.common.ModelType;
 import gov.cms.madie.models.measure.QdmMeasure;
-import jakarta.xml.bind.JAXBException;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.ExtendWith;
@@ -57,20 +56,6 @@ void generateHqmf() throws Exception {
     assertThat(output, is(equalTo("<QualityMeasureDocument></QualityMeasureDocument>")));
   }
 
-  @Test
-  void generateHqmfWhenSimpleXmlGenerationFailed() throws Exception {
-    String message = "An issue occurred while generating the simple xml for measure";
-    doThrow(new JAXBException(message))
-        .when(simpleXmlService)
-        .measureToSimpleXml(any(QdmMeasure.class));
-    Exception ex =
-        assertThrows(
-            PackagingException.class,
-            () -> hqmfService.generateHqmf(measure),
-            "Exception occurred");
-    assertThat(ex.getMessage(), containsString(message));
-  }
-
   @Test
   void generateHqmfWhenHqmfGenerationFailed() throws Exception {
     when(simpleXmlService.measureToSimpleXml(any(QdmMeasure.class)))