Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT- 6901 fix HQMF issues #16

Merged
merged 10 commits into from
Mar 11, 2024
Merged

MAT- 6901 fix HQMF issues #16

merged 10 commits into from
Mar 11, 2024

Conversation

adongare
Copy link
Contributor

@adongare adongare commented Mar 8, 2024

MADiE PR

Jira Ticket: MAT-6901
(Optional) Related Tickets:
related pr: MeasureAuthoringTool/madie-qdm-elm-translation#160

Summary

This PR contains fixes for following issues:

  • referential integrity among UUIDs referred
  • Measure References contain spaces. e.g. <value mediaType="text/plain" value="Citation test 2" xsi:type="ED"/>
  • missing precondition for criteriaReferences of a populationCriteriaSection components. rach population criteria refers to the UUID of root of the library for which it belongs to
  • Correcting URLs: all emasuretool urls should be replaced with madie.cms.gov
  • missing observation for ratio & CV - done. -done
  • functions(may have some issues, haven't tested yet)
  • missing populationCriteriaSection components for RAVs, STRAT

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@adongare adongare changed the title Mat 6901 MAT- 6901 fix HQMF issues Mar 8, 2024
@adongare adongare marked this pull request as ready for review March 8, 2024 21:38
@adongare adongare requested a review from a team as a code owner March 8, 2024 21:38
@adongare adongare merged commit 4de7d59 into develop Mar 11, 2024
6 checks passed
@adongare adongare deleted the MAT-6901 branch March 11, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants