Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-6180 Add ELM (XML and JSON) to QDM measure export #3

Merged
merged 7 commits into from
Dec 21, 2023
Merged

Conversation

adongare
Copy link
Contributor

@adongare adongare commented Dec 20, 2023

MADiE PR

Jira Ticket: MAT-6180 ) Add ELM (XML and JSON) to QDM measure export
(Optional) Related Tickets: MAT-6179 Add CQL Libraries to QDM measure export

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

MAT-6180 Add ELM (XML and JSON) to QDM measure export
@adongare adongare marked this pull request as ready for review December 20, 2023 21:19
@adongare adongare requested a review from a team as a code owner December 20, 2023 21:19
@jkotanchik-SB
Copy link
Contributor

jkotanchik-SB commented Dec 21, 2023

Even though we don't often use our services as build time dependencies in other places, I suggest renaming the base package from gov.cms.madie.madieqdmservice to gov.cms.madie.qdm.

jkotanchik-SB
jkotanchik-SB previously approved these changes Dec 21, 2023
@adongare adongare merged commit ef11e86 into develop Dec 21, 2023
5 checks passed
@adongare adongare deleted the MAT-6180 branch December 21, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants