Mat 7052 translator refactor 2 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adongare
reviewed
Aug 6, 2024
| private Set<Lookup> functions; | ||
| private Set<Lookup> fluentFunctions; | ||
|
|
||
| @Builder |
There was a problem hiding this comment.
I missed @Data annotation on this in the initial PR. Adding it would avoid serialization issues
adongare
reviewed
Aug 6, 2024
|
|
||
| @Data | ||
| @Builder | ||
| public class CqlLookups { |
There was a problem hiding this comment.
I think this is QDM specific class. Can live in QDM translator
There was a problem hiding this comment.
@adongare Moved it out and back to madie-qdm-elm-translation.
adongare
reviewed
Aug 6, 2024
| @AllArgsConstructor | ||
| @Builder(toBuilder = true) | ||
| @EqualsAndHashCode | ||
| public class ElementLookup { |
There was a problem hiding this comment.
this is QDM specific as well
There was a problem hiding this comment.
@adongare Done.
adongare
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.