Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAT-7190] Set HQMF ID and Display Data Element ID's as simple strings #11

Merged
merged 3 commits into from
May 15, 2024

Conversation

jkotanchik-SB
Copy link
Contributor

@jkotanchik-SB jkotanchik-SB commented May 14, 2024

MADiE PR

Jira Ticket: MAT-7190
(Optional) Related Tickets:

Summary

Various fixes for issues identified by SMEs:

  • MAT-7190: Gracefully handle empty, non-compliant measure input.
  • MAT-7190: Set the CQM::Measure HQMF ID as the madie measure ID.
  • MAT-7190: Display the Data Element's ID as a simple string value, instead of as "{$oid => "<_id>"}" in the QRDA XML.

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@jkotanchik-SB jkotanchik-SB requested a review from a team May 14, 2024 20:50
@jkotanchik-SB jkotanchik-SB requested a review from a team as a code owner May 14, 2024 20:50
@jkotanchik-SB jkotanchik-SB self-assigned this May 14, 2024
service/app.rb Show resolved Hide resolved
@jkotanchik-SB jkotanchik-SB merged commit 551db39 into develop May 15, 2024
6 checks passed
@jkotanchik-SB jkotanchik-SB deleted the feature/mat-7190-qrda-content-corrections branch May 15, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants