Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-7859: Guard against unexpected Value Set Status values by mapping them to UNKNOWN #105

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

jkotanchik-SB
Copy link
Contributor

@jkotanchik-SB jkotanchik-SB commented Oct 28, 2024

Terminology Service PR

Jira Ticket: MAT-7859
(Optional) Related Tickets:

Summary

When mapping SVS Value Sets to FHIR, map unknown Status values to FHIRPublication.UNKNOWN by handling the Exception thrown by HAPI's internal mapper.

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@jkotanchik-SB jkotanchik-SB requested a review from a team as a code owner October 28, 2024 18:52
@jkotanchik-SB jkotanchik-SB self-assigned this Oct 28, 2024
@jkotanchik-SB jkotanchik-SB changed the title MAT-7859: Guard against unexpected Value Set Status values by mapping them to FHIRPublication.UNKNOWN. MAT-7859: Guard against unexpected Value Set Status values by mapping them to UNKNOWN Oct 28, 2024
@jkotanchik-SB jkotanchik-SB merged commit 24edc4e into develop Oct 29, 2024
7 checks passed
@jkotanchik-SB jkotanchik-SB deleted the feature/mat-7859-add-default-vs-status branch October 29, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants