Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mat 7223/update logic for checking existing cql meta data #83

Merged

Conversation

sb-prateekkeerthi
Copy link
Contributor

@sb-prateekkeerthi sb-prateekkeerthi commented May 22, 2024

Terminology Service PR

Jira Ticket: MAT-7223
(Optional) Related Tickets:

Summary

update logic for checking existing cql meta data

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@sb-prateekkeerthi sb-prateekkeerthi requested a review from a team as a code owner May 22, 2024 22:42
Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 32.60870% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 76.80%. Comparing base (ef7d1fc) to head (9393c2a).
Report is 9 commits behind head on develop.

Files Patch % Lines
...ie/terminology/service/FhirTerminologyService.java 29.54% 25 Missing and 6 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop      #83      +/-   ##
=============================================
+ Coverage      76.52%   76.80%   +0.27%     
- Complexity       219      224       +5     
=============================================
  Files             23       23              
  Lines            916      927      +11     
  Branches          72       76       +4     
=============================================
+ Hits             701      712      +11     
+ Misses           179      178       -1     
- Partials          36       37       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sb-prateekkeerthi sb-prateekkeerthi merged commit 1d34798 into develop May 24, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants