feat: Upgrade to JDK 21 #91

boubaker · 2023-09-19T17:37:46Z

Rationale

JDK 21 is the latest LTS version and we should migrate into it to benifit from its dvantages and to keep possibility of supporting a "supported JDK" for customers contexts.

1. Functional Requirements

Impacts

Gamification

Notifications

Analytics

Unified Search

2. Technical Requirements

Expected Volume & Performance

Security

Extensibility

Configurability

Upgradability

Existing Features

Feature Flags

Property Name	Default Value	Target Audience	Functional Behaviour

Other Non Functional Requirements

3. Impacts

Documentation

Training

4. Software Architecture

Security

Access

GUI
API

Services & processing

Ex: Scheduled Jobs

Data and persistence

Macro data model
Persistence layer
Use of caches

Clustering

Multitenancy

Integrations

Migration strategy

5. Annexes

Reasoning that explain the technical choices
Impacts
References

rdenarie · 2024-05-03T07:45:34Z

As there is no architectural nor functionnal impact, can we give go func and go tech on this MIP ?

cc @boubaker

Before this fix, we use lombok-maven-plugin version 1.18.20.0 which use lombok 1.18.20 which is not compatible with jdk21. This fix is a workaround waiting this pr to be merged : awhitford/lombok.maven#180 and a new artifact released Resolves Meeds-io/MIPs#91

Adapt coverage ratio Resolves Meeds-io/MIPs#91

Before this fix, the simpleDateFormat for locale en is MM/dd/yyyy, HH:mm:ss a In jdk17 and under, the space between 'ss' and 'a' is a simple space In JDK 21, the space was changed to '[NNBSP]a' ([OpenJDK information](https://bugs.openjdk.org/browse/JDK-8324665)) : , so the .contains(" a") returns always false This commit add the test on '[NNBSP]a' in addition of ' a' in order to make it work on both jdk version It also add surefire configuration to work with jdk21 Resolves Meeds-io/MIPs#91

rdenarie · 2024-05-03T07:52:11Z

Boubaker's remark :

Besides, I think we should do a deep cleanup to delete the usage of Security Manager in Core Foundation projects, see https://nipafx.dev/road-to-21-upgrade/ for more information about changes to take care of.

boubaker · 2024-05-03T07:52:23Z

Done, Besides, we may need to upgrade to latest Spring Maintenance version 3.2.5 as well to ensure compatibility with upgraded third party libraries and latest fixes.

This commit upgrade the spring boot version to the last one available Resolves Meeds-io/MIPs#91

Remove SecurityManager from Kernel as it is deprecated for removal in jdk21 Remove also classes - SecurityHelper - PrivilegedSystemHelper - PrivilegedFileHelper - SecureList - SecureSet - SecureCollections These classes are here only to use securityManager, and as it is removed, it is no more necessary Resolves Meeds-io/MIPs#91

Remove usage of SecurityManager as it is deprecated for removal in jdk21 Remove also usage of classes - SecurityHelper - PrivilegedSystemHelper - PrivilegedFileHelper - SecureList - SecureSet - SecureCollections These classes are here only to use securityManager, and as it is removed, it is no more necessary Resolves Meeds-io/MIPs#91

Remove usage of SecurityManager as it is deprecated for removal in jdk21 Remove also usage of classes - SecurityHelper - PrivilegedSystemHelper - PrivilegedFileHelper - SecureList - SecureSet - SecureCollections These classes are here only to use securityManager, and as it is removed, it is no more necessary