Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement Platform settings site - Meeds-io/MIPs#88 #286

Merged
merged 3 commits into from
Nov 25, 2023

Conversation

azayati
Copy link
Member

@azayati azayati commented Oct 20, 2023

No description provided.

@azayati azayati linked an issue Oct 20, 2023 that may be closed by this pull request
@azayati azayati marked this pull request as ready for review November 25, 2023 00:30
@azayati azayati requested a review from boubaker November 25, 2023 00:52
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

boubaker

This comment was marked as duplicate.

Copy link
Member

@boubaker boubaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The result is different from what we decided in meeting together (@rdenarie @azayati). The site definition should be centralized in sites.war to simplify its maintenance. For wallet & perk store, we decided to define it in sites.war using profiles to import it only when needed.
To not block the merge, ok for me to go to develop, we 'll see it later.

@azayati azayati merged commit 7bd18df into develop Nov 25, 2023
6 checks passed
@azayati azayati deleted the mergeMIP88 branch November 25, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: New site : Platform settings
3 participants