feat: Fix image resizing issue - EXO-74758 - Meeds-io/MIPs#145 #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdenarie
requested changes
Nov 19, 2024
There was a problem hiding this comment.
Can you add your PR description in the commit message ?
You Pr comment is perfect, it explains the problem, how you fix it ... All informations are present
BUT it will be lost when the PR will be merged.
Put this comment in the commit so that the information is not lost
Prior to this change, resizing an inserted image in the editor was not possible.The resizer remained attached to the mouse and only detached when clicking outside the editor.This change addresses the issue by attaching the pointerup event to the document instead of the mouseup event.
|
rdenarie
approved these changes
Nov 20, 2024
done ! |
exo-swf
pushed a commit
that referenced
this pull request
Nov 21, 2024
Prior to this change, resizing an inserted image in the editor was not possible. The resizer remained attached to the mouse and only detached when clicking outside the editor. This change addresses the issue by attaching the pointerup event to the document instead of the mouseup event
exo-swf
pushed a commit
that referenced
this pull request
Nov 23, 2024
Prior to this change, resizing an inserted image in the editor was not possible. The resizer remained attached to the mouse and only detached when clicking outside the editor. This change addresses the issue by attaching the pointerup event to the document instead of the mouseup event
sofyenne
added a commit
that referenced
this pull request
Nov 28, 2024
Prior to this change, resizing an inserted image in the editor was not possible. The resizer remained attached to the mouse and only detached when clicking outside the editor. This change addresses the issue by attaching the pointerup event to the document instead of the mouseup event
sofyenne
added a commit
that referenced
this pull request
Nov 28, 2024
Prior to this change, resizing an inserted image in the editor was not possible. The resizer remained attached to the mouse and only detached when clicking outside the editor. This change addresses the issue by attaching the pointerup event to the document instead of the mouseup event
sofyenne
added a commit
that referenced
this pull request
Nov 28, 2024
Prior to this change, resizing an inserted image in the editor was not possible. The resizer remained attached to the mouse and only detached when clicking outside the editor. This change addresses the issue by attaching the pointerup event to the document instead of the mouseup event
sofyenne
added a commit
that referenced
this pull request
Nov 28, 2024
Prior to this change, resizing an inserted image in the editor was not possible. The resizer remained attached to the mouse and only detached when clicking outside the editor. This change addresses the issue by attaching the pointerup event to the document instead of the mouseup event
sofyenne
added a commit
that referenced
this pull request
Nov 28, 2024
Prior to this change, resizing an inserted image in the editor was not possible. The resizer remained attached to the mouse and only detached when clicking outside the editor. This change addresses the issue by attaching the pointerup event to the document instead of the mouseup event
sofyenne
added a commit
that referenced
this pull request
Nov 29, 2024
Prior to this change, resizing an inserted image in the editor was not possible. The resizer remained attached to the mouse and only detached when clicking outside the editor. This change addresses the issue by attaching the pointerup event to the document instead of the mouseup event
sofyenne
added a commit
that referenced
this pull request
Dec 12, 2024
Prior to this change, resizing an inserted image in the editor was not possible. The resizer remained attached to the mouse and only detached when clicking outside the editor. This change addresses the issue by attaching the pointerup event to the document instead of the mouseup event
exo-swf
pushed a commit
that referenced
this pull request
Dec 13, 2024
Prior to this change, resizing an inserted image in the editor was not possible. The resizer remained attached to the mouse and only detached when clicking outside the editor. This change addresses the issue by attaching the pointerup event to the document instead of the mouseup event
sofyenne
added a commit
that referenced
this pull request
Dec 13, 2024
Prior to this change, resizing an inserted image in the editor was not possible. The resizer remained attached to the mouse and only detached when clicking outside the editor. This change addresses the issue by attaching the pointerup event to the document instead of the mouseup event
exo-swf
pushed a commit
that referenced
this pull request
Dec 17, 2024
Prior to this change, resizing an inserted image in the editor was not possible. The resizer remained attached to the mouse and only detached when clicking outside the editor. This change addresses the issue by attaching the pointerup event to the document instead of the mouseup event
rdenarie
pushed a commit
that referenced
this pull request
Dec 17, 2024
Prior to this change, resizing an inserted image in the editor was not possible. The resizer remained attached to the mouse and only detached when clicking outside the editor. This change addresses the issue by attaching the pointerup event to the document instead of the mouseup event
rdenarie
pushed a commit
that referenced
this pull request
Dec 17, 2024
Prior to this change, resizing an inserted image in the editor was not possible. The resizer remained attached to the mouse and only detached when clicking outside the editor. This change addresses the issue by attaching the pointerup event to the document instead of the mouseup event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, resizing an inserted image in the editor was not possible. The resizer remained attached to the mouse and only detached when clicking outside the editor. This change addresses the issue by attaching the pointerup event to the document instead of the mouseup event