Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport/task 69432 69702 #38

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Backport/task 69432 69702 #38

merged 2 commits into from
Feb 20, 2024

Conversation

rdenarie
Copy link
Member

No description provided.

…XO-69432

Before this fix, SAML authentication require username as subject in the SAML assertion response.

As for the login (in which we are able to log with username or email), we would propose to have the email as subject of the assertion.
The class SAML2IntegrationLoginModule is never used during SAML workflow
This commit remove the class
@rdenarie rdenarie requested review from mkrout and Jihed525 February 20, 2024 08:14
@rdenarie rdenarie enabled auto-merge (rebase) February 20, 2024 08:15
Copy link

sonarcloud bot commented Feb 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

@rdenarie rdenarie merged commit 0ffbd22 into develop Feb 20, 2024
3 of 4 checks passed
@rdenarie rdenarie deleted the backport/task-69432 branch February 20, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants