Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:Sites Management Card review - MEED-7165 - Meeds-io/MIPs#137 #159

Merged
merged 2 commits into from
Jul 9, 2024
Merged

feat:Sites Management Card review - MEED-7165 - Meeds-io/MIPs#137 #159

merged 2 commits into from
Jul 9, 2024

Conversation

SaraBoutej
Copy link
Contributor

No description provided.

@SaraBoutej SaraBoutej requested a review from boubaker July 9, 2024 08:07
@github-actions github-actions bot added the partialCIBuild Perform Partial CI Build label Jul 9, 2024
boubaker
boubaker reviewed Jul 9, 2024
View reviewed changes
.../vue-app/common-layout-components/components/site-navigation/SiteNavigationPageSuggester.vue Outdated
@@ -181,6 +181,7 @@ export default {
}, this.endTypingKeywordTimeout);
},
emitSelectedValue(value) {
console.warn('olaaaaa');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
console.warn('olaaaaa');

@SaraBoutej SaraBoutej requested a review from boubaker July 9, 2024 08:30
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@SaraBoutej SaraBoutej merged commit b745a3f into feature/meedsv2 Jul 9, 2024
5 checks passed
@SaraBoutej SaraBoutej deleted the meed-7165 branch July 9, 2024 08:33
boubaker pushed a commit that referenced this pull request Jul 10, 2024
@SaraBoutej @boubaker
feat:Sites Management Card review - MEED-7165 - Meeds-io/MIPs#137 (#159)
24ceaa1
SaraBoutej added a commit that referenced this pull request Jul 22, 2024
@SaraBoutej
feat:Sites Management Card review - MEED-7165 - Meeds-io/MIPs#137 (#159)
a941dbe
SaraBoutej added a commit that referenced this pull request Jul 22, 2024
@SaraBoutej
feat:Sites Management Card review - MEED-7165 - Meeds-io/MIPs#137 (#159)
5f72c19
SaraBoutej added a commit that referenced this pull request Jul 22, 2024
@SaraBoutej
feat:Sites Management Card review - MEED-7165 - Meeds-io/MIPs#137 (#159)
3c64e6c
SaraBoutej added a commit that referenced this pull request Jul 22, 2024
@SaraBoutej
feat:Sites Management Card review - MEED-7165 - Meeds-io/MIPs#137 (#159)
5546600
exo-swf pushed a commit that referenced this pull request Aug 16, 2024
@SaraBoutej
feat:Sites Management Card review - MEED-7165 - Meeds-io/MIPs#137 (#159)
f7661ed
exo-swf pushed a commit that referenced this pull request Aug 21, 2024
@SaraBoutej
feat:Sites Management Card review - MEED-7165 - Meeds-io/MIPs#137 (#159)
9106820
exo-swf pushed a commit that referenced this pull request Aug 22, 2024
@SaraBoutej
feat:Sites Management Card review - MEED-7165 - Meeds-io/MIPs#137 (#159)
868311d
exo-swf pushed a commit that referenced this pull request Aug 22, 2024
@SaraBoutej @exo-swf
feat:Sites Management Card review - MEED-7165 - Meeds-io/MIPs#137 (#159)
f4fbf7d
exo-swf pushed a commit that referenced this pull request Aug 23, 2024
@SaraBoutej
feat:Sites Management Card review - MEED-7165 - Meeds-io/MIPs#137 (#159)
228ce0f
exo-swf pushed a commit that referenced this pull request Aug 24, 2024
@SaraBoutej
feat:Sites Management Card review - MEED-7165 - Meeds-io/MIPs#137 (#159)
2e19397
boubaker pushed a commit that referenced this pull request Aug 27, 2024
@SaraBoutej @boubaker
feat:Sites Management Card review - MEED-7165 - Meeds-io/MIPs#137 (#159)
90b77dc
exo-swf pushed a commit that referenced this pull request Aug 28, 2024
@SaraBoutej
feat:Sites Management Card review - MEED-7165 - Meeds-io/MIPs#137 (#159)
e42fa7e
SaraBoutej added a commit that referenced this pull request Aug 29, 2024
@SaraBoutej
feat:Sites Management Card review - MEED-7165 - Meeds-io/MIPs#137 (#159)
5eb7c7f
SaraBoutej added a commit that referenced this pull request Aug 29, 2024
@SaraBoutej
feat:Sites Management Card review - MEED-7165 - Meeds-io/MIPs#137 (#159)
ab4e55b
exo-swf pushed a commit that referenced this pull request Aug 29, 2024
@SaraBoutej
feat:Sites Management Card review - MEED-7165 - Meeds-io/MIPs#137 (#159)
7ab4e23
SaraBoutej added a commit that referenced this pull request Aug 29, 2024
@SaraBoutej
feat:Sites Management Card review - MEED-7165 - Meeds-io/MIPs#137 (#159)
d818a7f
SaraBoutej added a commit that referenced this pull request Aug 30, 2024
@SaraBoutej
feat:Sites Management Card review - MEED-7165 - Meeds-io/MIPs#137 (#159)
522c662 
(cherry picked from commit e42fa7e)
exo-swf pushed a commit that referenced this pull request Aug 30, 2024
@SaraBoutej @exo-swf
feat:Sites Management Card review - MEED-7165 - Meeds-io/MIPs#137 (#159)
efd15ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boubaker boubaker Awaiting requested review from boubaker

Assignees
No one assigned
Labels
partialCIBuild Perform Partial CI Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SaraBoutej @boubaker