Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Display Tooltip When No Instance Preview available - MEED-6956 - Meeds-io/MIPs#139 #91

Merged
merged 1 commit into from
May 30, 2024
Merged

feat: Display Tooltip When No Instance Preview available - MEED-6956 - Meeds-io/MIPs#139 #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions layout-webapp/src/main/resources/locale/portlet/LayoutEditor_en.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,3 +286,4 @@ portlets.noPortletInstancesYet=Create your first instance using this portlet
portlets.instancePreview=Preview
portlets.uploadPreviewTitle=Upload an illustration for portlet instance
portlets.label.createInstance=Create instance
portlets.noPreviewAvailable=No preview available
9 changes: 3 additions & 6 deletions layout-webapp/src/main/webapp/vue-app/portlets/components/PortletsManagement.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,11 @@
class="card-border-radius overflow-hidden"
@portlet-instance-filter="keyword = $event"
@select-tab="selectTab" />
<portlets-list
v-if="tabName === 'portlets'"
ref="portlets"
class="card-border-radius overflow-hidden"
:keyword="keyword" />
<portlets-instance-main
v-if="tabName === 'instances'"
ref="instances"
:keyword="keyword" />
<portlets-list
v-else-if="tabName === 'portlets'"
:keyword="keyword" />
</v-card>
<portlets-item-instances-drawer />
Expand Down
2 changes: 1 addition & 1 deletion layout-webapp/src/main/webapp/vue-app/portlets/components/portlets/List.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
must-sort
disable-pagination
hide-default-footer
class="portletsTable px-5">
class="card-border-radius overflow-hidden portletsTable px-5">
<template slot="item" slot-scope="props">
<portlets-item
:key="props.item.id"
Expand Down
20 changes: 11 additions & 9 deletions ...ut-webapp/src/main/webapp/vue-app/portlets/components/portlets/drawer/InstancesDrawer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,17 +55,19 @@
<v-list-item-action class="my-auto me-4">
<v-tooltip bottom>
<template #activator="{on, attrs}">
<v-btn
<div
v-on="on"
v-bind="attrs"
:disabled="!application.illustrationId"
class="transparent d-flex align-center justify-center"
icon
@click="openIllustration(application)">
<v-icon class="icon-default-color">fa-eye</v-icon>
</v-btn>
v-bind="attrs">
<v-btn
:disabled="!application.illustrationId"
class="transparent d-flex align-center justify-center"
icon
@click="openIllustration(application)">
<v-icon class="icon-default-color">fa-eye</v-icon>
</v-btn>
</div>
</template>
<span>{{ $t('portlets.previewInstance') }}</span>
<span>{{ application.illustrationId && $t('portlets.previewInstance') || $t('portlets.noPreviewAvailable') }}</span>
</v-tooltip>
</v-list-item-action>
</v-list-item>
Expand Down
Loading