-
Notifications
You must be signed in to change notification settings - Fork 9
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: Enhance Topbar Buttons Tooltips - MEED-7848 - Meeds-io/meeds#2644
Prior to this change, the Browser Tooltip was used for some Topbar Icons. This change will force usage of Vuetify Tooltips to enhance UX when hovering the icons for the first time by a user. This will degrade the page rendering performances but in favor of a UX.
- Loading branch information
Showing
14 changed files
with
153 additions
and
79 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1931,7 +1931,7 @@ | |
</depends> | ||
</module> | ||
</portlet> | ||
|
||
<portlet> | ||
<name>PlatformSettings</name> | ||
<module> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 changes: 47 additions & 0 deletions
47
webapp/src/main/webapp/WEB-INF/jsp/portlet/topbarFavorites.jsp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
<%@page import="org.exoplatform.container.ExoContainerContext"%> | ||
<%@page import="java.util.Locale"%> | ||
<%@page import="org.exoplatform.services.resources.ResourceBundleService"%> | ||
<%@page import="java.util.ResourceBundle"%> | ||
<% | ||
ResourceBundle bundle; | ||
try { | ||
bundle = ExoContainerContext.getService(ResourceBundleService.class).getResourceBundle("locale.portlet.Portlets", request.getLocale()); | ||
} catch (Exception e) { | ||
bundle = ExoContainerContext.getService(ResourceBundleService.class).getResourceBundle("locale.portlet.Portlets", Locale.ENGLISH); | ||
} | ||
String tooltip = bundle.getString("Search.button.tooltip"); | ||
%> | ||
<div class="VuetifyApp"> | ||
<div | ||
id="favoritesListPortlet" | ||
data-app="true" | ||
class="v-application v-application--is-ltr theme--light"> | ||
<div class="v-application--wrap d-none"> | ||
<v-tooltip bottom> | ||
<template #activator="{on, attrs}"> | ||
<v-btn | ||
v-on="on" | ||
v-bind="attrs" | ||
aria-label="<%=tooltip%>" | ||
icon | ||
class="transparent" | ||
@click="Vue.startApp('PORTLET/social/TopBarFavorites', 'init')"> | ||
<v-icon size="20">fa-star</v-icon> | ||
</v-btn> | ||
</template> | ||
<span class="tooltip"><%=tooltip%></span> | ||
</v-tooltip> | ||
</div> | ||
</div> | ||
<script type="text/javascript"> | ||
window.require(['SHARED/commonVueComponents', 'SHARED/vuetify'], () => { | ||
new Vue({ | ||
el: '#favoritesListPortlet', | ||
vuetify: Vue.prototype.vuetifyOptions, | ||
mounted() { | ||
document.querySelector('#favoritesListPortlet .v-application--wrap').classList.remove('d-none'); | ||
}, | ||
}); | ||
}); | ||
</script> | ||
</div> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
9 changes: 6 additions & 3 deletions
9
webapp/src/main/webapp/vue-apps/common/components/Notifications.vue
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters