-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Sidebar and Topbar Review - Meeds-io/MIPs#159 #4250
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boubaker
force-pushed
the
merge-mip-159
branch
from
December 9, 2024 10:21
af75309
to
0005a93
Compare
AzmiTouil
approved these changes
Dec 9, 2024
…s-io/MIPs#159 (#4196) This change will add Backend and Basic Frontend for Topbar and Sidebar configuration.
…-io/MIPs#159 (#4197) This change will allow to add Spaces in the Left Menu per Space Template. feat: Adjust Default Sidebar configuration on first Server startup - MEED-7833 - Meeds-io/MIPs#159 (#4198) Adjust default Sidebar Mode configuration on first server startup including this new feature.
… (#4200) Allow to select a specific icon when adding a site or a page.
…eeds-io/MIPs#159 (#4201) Refactor Sidebar to introduce sidebar settings from admin UI
- Meeds-io/MIPs#159 (#4204) This change will allow to define a specific order to display space templates in Sidebar.
…ds-io/MIPs#159 (#4206) This change will allow to access to space list from Sidebar by space template and switch designated sort type. In addition, an expand behavior has been added to space template group to allow user to change how the menu should look by default when displaying the page.
…D-7798 - Meeds-io/MIPs#159 Add unread and favorite filter in Second Level of Spaces and space templates of Sidebar
This change will allow to open Sidebar when Hidden only when clicking on Hamburger Button and no more using the Hover effect to open the sidebar.
…59 (#4209) This change will review the Spaces Creation form to adopt the fields selection Inputs display switch selected Template.
…o/MIPs#159 (#4210) Add button from Spaces List drawer to access Space Form Drawer.
…s-io/MIPs#159 (#4216) Prior to this change, the settings was lightweighted in Service JS file before sent to server, making the changes on the original Vue object. This change ensures to make the lightweight operation in a cloned object instead of the original one.
…-7892 - Meeds-io/MIPs#159 (#4217) This change will switch to icon mode when the resolution is under 1263 and more than 959 when the user had selected the 'STICKY' mode.
…MEED-7885 - Meeds-io/MIPs#159 (#4218) This change will make the Platform logo displayed with the following proportions: - height is 36px min/max - Width is 100px max - 100% of the width must be displayed In addition, the Burger icon size is reviewed to match the topbar icons size: - Burger icon font-size: 20px
…#4219) This change will reduce the Space avatar size to 28 instead of 36.
…m Topbar Settings - MEED-7889 - Meeds-io/MIPs#159 (#4220) This change will ensure to display full company name and logo in standalone sites independently from what is configured for shared layout based sites.
…-io/MIPs#159 (#4222) This change will allow to display page icon and title when it's defined in Meta site rather than no display.
- Meeds-io/MIPs#159 (#4225) This change will fix the passed parameter to distinguish whether the External Users invitation using email is enabled or not.
…7875 - Meeds-io/MIPs#159 (#4227) This change will allow to remove the inputs from layout addon which asks the user to choose whether to display or not the Shared Layout for a Site in addition to the fact to choose whether the site is displayed in Sidebar or not, with its display order. Thus, with this change, the Shared layout will be displayed automatically only when the Site is a designated item added in the Sidebar configuration.
…7896 - Meeds-io/MIPs#159 (#4230) Prior to this change, when the Notification Extensions are loaded in a deferred way, the associated extension of a notification type didn't refresh to get the right associated Notification Extension due to missing Vue Listener on Vue Object attributes. This change will force the refresh by introducing a listener event triggered when the extensions list is refreshed. In addition, a loading visual effect is added to notification button to enhance user UX while opening the notifications Drawer.
…eeds-io/MIPs#159 (#4231) This change will enhance the UX when browsing spaces from Sidebar by disabling collapsing and expanding behavior on Space Templates.
…s-io/MIPs#159 (#4238) This change will allow to change display order index of sites when changing it in Sidebar configuration.
…m Scroll position - MEED-7907 - Meeds-io/MIPs#159 (#4243)
…4245) This change will introduce a new option to allow displaying or not Spaces items in Side bar when user isn't member of spaces associated to a given Space Template.
Prior to this change, when an application is added to Topbar Addon Cotnainer without a fixed configured Id, then the application is added again in listed Topbar Applications each startup. This change ensures to fix the id by using the Application contentId if it's the case.
Prior to this change, the target external link of sidebar items was all time 'NEW TAB Strategy' and without a 'rel' attribute. This change will fix the behavior of 'External Link Target' in addition to the Security fix of missing 'rel' attribute.
boubaker
force-pushed
the
merge-mip-159
branch
from
December 9, 2024 11:13
0005a93
to
cec2456
Compare
Quality Gate failedFailed conditions See analysis details on SonarQube Cloud Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Meeds-io/MIPs#159