fix: Fix computing of RTL based Language for Card Carousel Arrows - MEED-7912 - Meeds-io/meeds#2652 #4252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AzmiTouil
approved these changes
Dec 9, 2024
…ows - MEED-7912 - Meeds-io/meeds#2652 Prio tot his change, some changes were made to make the Card caroussel Arrows works on RTL based Locales which had made some regressions on LTR based languages. This change will revert recent changes and rework the RTL computing algorithms to consider RTL Javascript offset computing.
|
rdenarie
pushed a commit
that referenced
this pull request
Dec 9, 2024
…EED-7912 - Meeds-io/meeds#2652 (#4252) Prior to his change, some changes were made to make the Card carousel Arrows works on RTL based Locales which had made some regressions on LTR based languages. This change will revert recent changes and rework the RTL computing algorithms to consider RTL DOM offset computing. Resolves Meeds-io/meeds#2652
rdenarie
pushed a commit
that referenced
this pull request
Dec 9, 2024
…EED-7912 - Meeds-io/meeds#2652 (#4252) Prior to his change, some changes were made to make the Card carousel Arrows works on RTL based Locales which had made some regressions on LTR based languages. This change will revert recent changes and rework the RTL computing algorithms to consider RTL DOM offset computing. Resolves Meeds-io/meeds#2652
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to his change, some changes were made to make the Card carousel Arrows works on RTL based Locales which had made some regressions on LTR based languages. This change will revert recent changes and rework the RTL computing algorithms to consider RTL DOM offset computing.
Resolves Meeds-io/meeds#2652